I’ve been working with @profezzorn to address the false clashes from speaker vibrations and we have a potential solution but need more testing.
I didn’t actually have any sabers that exhibit this behavior but I was able to replicate by leaving the bottom half of a hilt off and lowering the CLASH_THRESHOLD_G for one of my sabers so I used it to test. Now we need to have users who’ve actually had this issue to help test and prove it out.
POC (Test 1):
I have set up a fork with the changes for testing. Go to this page and click the green “Code” button, then select “Download Zip”
There is a new define that lets you set the suppression level for audio
#define AUDIO_CLASH_SUPPRESSION_LEVEL 20
The range for this define is 1 ~ 50 with 1 having almost no suppression for audio and 50 being really high suppression (although the highest I needed during testing was 20 to get desired result).
This define works in conjunction with your CLASH_THRESHOLD_G and to some extent your VOLUME, so users can also use a lower suppression level to be able to increase the volume or lower the CLASH_THRESHOLD_G and increase the sensitivity of the saber.
As a start point my test saber these were the config values I had (although I had to try to recreate this issue so users will need to determine the “Goldilocks” values for their saber:
#define VOLUME 1800 #define CLASH_THRESHOLD_G 3.0 #define AUDIO_CLASH_SUPPRESSION_LEVEL 20
The higher the AUDIO_CLASH_SUPPRESSION_LEVEL the lower you should be able to set CLASH_THRESHOLD_G, you may also be able to increase the VOLUME and not get false clashes but you want to be mindful of what your speaker can handle so you don’t damage the speaker by setting volume too high.
I typically change CLASH_THRESHOLD_G by either 0.25 or 0.5 increments and the AUDIO_CLASH_SUPRESSION_LEVEL by 5s to find the right balance.
I would recommend testing on loud, bassy fonts and run through your accent swings, quotes, force, tracks as those were the sounds that seemed to cause the most false clashes for me. Some fonts and sounds are more likely to trigger false clashes so you’ll want to find the config values that handle everything while still letting you trigger actual clashes as usual.
Note if you set the AUDIO_CLASH_SUPPRESSION_LEVEL too high it will become very hard to trigger any clashes so start around 20 and adjust up or down to determine the best level.
Please reply to this thread if this resolves your issue of false clashes from sounds or if it doesn’t post the values you’re testing so we can see if adjusting helps.