Why there is no serial command for the Swing sounds?

ShtokyD · November 29, 2024, 8:31pm

Can we please have? Also Spin or Slash if those are recognized by ProffieOS?

profezzorn · November 29, 2024, 8:42pm

Pull requests are welcome.

NoSloppy · December 10, 2024, 6:02am

@ShtokyD We can play anything in the font search path with “play”.

play swng.wav
play slsh.wav
play spin.wav

Are you saying you need a shortcut directly like just:

swng
slsh
spin

?
@profezzorn Are you saying you’re open to add said shortcuts?

profezzorn · December 10, 2024, 6:39am

Sure, they wouldn’t take up much memory.

ShtokyD · December 11, 2024, 3:23pm

Yes, please add those shortcuts.

NoSloppy · December 16, 2024, 9:49am

Starting to work on coding this.
I found what seems to be a redundancy and want to confirm.
We couldn’t even be here unless this were already true at line 294, yes?

github.com

profezzorn/ProffieOS/blob/ed595f7a419388277e54eea942d78c9c424e58c9/sound/hybrid_font.h#L336


      
          #ifdef ENABLE_SPINS
                      if (angle_ > font_config.ProffieOSSpinDegrees) {
                        if (SFX_spin) {
                          swing_player_ = PlayPolyphonic(&SFX_spin);
                        }
                        angle_ -= font_config.ProffieOSSpinDegrees;
                      }
          #endif
                    }
                  }
                } else if (swing_speed > swingThreshold) {
                  if (!swinging_) {
                    PlayMonophonic(&SFX_swing, &SFX_hum);
                    swinging_ = true;
                  }
          #ifdef ENABLE_SPINS
                  if (angle_ > 360 && swinging_) {
                    if (SFX_spin) {
                      PlayMonophonic(&SFX_spin, &SFX_hum);
                    }
                    angle_ -= font_config.ProffieOSSpinDegrees;

profezzorn · December 16, 2024, 9:57am

Agreed, that looks redundant.

NoSloppy · December 16, 2024, 10:58pm

Additionally, I am having a tough time following the logic for monophonic/polyphonic guessing and use. I suppose that’s because I haven’t encountered a monophonic Crystal Focus font in many years.
I have a concern that the naming convention is not enough to use as a determining factor, given that in the lastest downloadable package of default fonts from them, there’s a mix of hum, humm, humM1, yet there are smoothswing sounds in some that should be mono according to the hybrid_font logic, as well as clash and blaster being used for either poly/mono apparently.
This is tough to support for backward compatibility the way it currently discriminates.

I am focusing just on making something for the poly decision work for now.

profezzorn · December 17, 2024, 12:01am

guess_monophonic is only used for effects that have the same name for monophonic and polyphonic fonts. So, for clsh and clash we already know if it’s monophonic or not based on the name, but for “force” we don’t know, so we base our guess based on what other files are present.

I’m not sure what you mean by this.
Smoothswing sounds (swingh/swingl) are by definition not monophonic.
Are you talking about accent swings/slashes/spins? Or something else?

However, it is possible to use swingh/swingl sounds with a font that is otherwise monophonic. Smoothswing is conceived as being a layer on top of a regular font, and that regular font can in theory be either monophonic or polyphonic.