I’m coming across an anomaly here with the hev prop.
Armor fill is essentially LOCKUP_LIGHTNING_BLOCK.
The blade style uses LockupTrL<…SaberBase::LOCKUP_LIGHTNING_BLOCK> which of course has its own built-in begin and endlock transitions, and there’s no separate EFFECT_LIGHTNING_BLOCK_END available.
However, if armor is already full and the user tries to fill, the prop immediately calls DoEndLockup(), and although the bgn/endlb sounds play (but only endlb is heard…), the transition animation does not show.
As opposed to IncreaseHealth, which has the same routine in the prop but uses LOCKUP_NORMAL, and has the end transition broken out into its own TransitionEffectL<…EFFECT_LOCKUP_END>. That animation does show if health is already at 100% when the Lockup is attempted.
I feel like regardless of the reason it behaves this way with the integrated transitions in the LockupTrL template, the “fix” would be to just break the END to its own TransitionEffectL, but we’d need the EFFECT to exist.
I also came across the “use” or at least the logical need (with the introduction of sound) to flesh out the Style Editor by adding
MELT_BEGIN
MELT_END
LB_BEGIN
LB_END.
For a long time I was thinking that lockups shouldn’t have events. Styles and other things should just check the lockup state and detect when it changes. Having paired events for each lockup state takes up memory and adds complication.
However, as time goes by, we’ve moved more and more towards using events for just about everything, so maybe we should have begin/end events for all lockup states. (And other types of states too.)
In fact, maybe issuing events is how you change state. This is what we do for “alternatives”, and maybe lockups and other states should work that way too?
The more everything works the same, the more opportunities there are for sharing code, so maybe going all in on events won’t use up a lot of memory and cause a bunch of extra complication?
I feel like we’ve had this discussion before somewhere…
Yeah, we were discussing earlier this year but with everything going on it kinda got lost in the mix. I replied to the PM to bring it back to the front if you wanted to refresh the conversation.
I’ll just chime in to say event begin and end add-on sounds etc are something I use and put into bladestyles/fontpacks a ton and also did it for a T.D. so yeah, I’d like to see it added. After all it’s only code. Maybe as a side project (trial period) to see if it’s viable to put into a final version?