SD Card Not Found Mystery

profezzorn · December 6, 2022, 8:12am

Mostly. Everything will work the same as long as you don’t try to look inside the savefiles. If you want to read or modify the savefiles from outside of ProffieOS, some additional steps will be needed.

Modifying the safefiles directly is definitely peeking under the hood though…

Sabersense · December 6, 2022, 8:32am

Thanks Prof.
Yeh I’ve never been one to mess with save files (other than simply deleting them) as I’ve always felt its too easy to cause conflicts with them. I think it sometimes gets to a point where learning how to tweak them safely is no less complicated than learning how to upload a new config.
Thanks for clarifying though.

NoSloppy · July 21, 2023, 9:59pm

The added routine in the VERBOSE_SD_ERRORS condition fixes this mystery?

Random SD card mounting failures on OS7, with an odd fix? Proffieboards

I’ve had this specific saber for about a month. This issue only started happening yesterday. One of two things happen: I get random SD card not found errors upon de-activating the killswitch. Lights on chassis/hilt turn on. I get no verbal error, and nothing seemingly happens when I de-activate the killswitch. No lights, saber doesn’t work. This doesn’t happen if I take the SD card out, however. Also, if I attempt to plug it into the computer in this “frozen” state, my PC does not register the board. I was able to narrow this down to this likely being the board. Things I’ve tried: 3 known good SD cards. Kingston industrial, SanDisk Ultra, and an E123. Formatted all of them Tried older configs which did not have these issues sdtest in serial monitor shows no issues with the reading ability on any of the cards… 1000-1400kb/s depending on the card. The saber functions as normal once the SD card manages to mount Onto the weird fix: Upon defining ‘VERBOSE_SD_ERRORS’ in my config (using the master branch of ProffieOS), my issues literally vanished into thin air. I was able to get successful consecutive boots counting to over 100, never got a single error or a freeze. I re-wrote the same config to my board, without ‘VERBOSE_SD_ERRORS’, and I was having issues again. More than half the time, my board was failing to mount the SD card. And I again put the ‘VERBOSE_SD_ERRORS’ define back in my config, wrote it to board, and I got another 100+ successful consecutive boots. Lastly, here is my config that is currently written to the board. war_config.h (59.0 KB)

For reference, this is the section of code:

github.com

profezzorn/ProffieOS/blob/015468fffdfae907e6150c6ce7a80ca381e6f7f3/common/lsfs.h#L312


      
              if (device->lock & DOSFS_DEVICE_LOCK_SCSI)
                strcat(tmp, " scsi");
              if (device->lock & DOSFS_DEVICE_LOCK_MEDIUM)
                strcat(tmp, " medium");
              if (device->lock & DOSFS_DEVICE_LOCK_INIT)
                strcat(tmp, " init");
            }
            // This function waits until the volume is mounted.
            static bool Begin() {
              if (mounted_) return true;
          #ifdef VERBOSE_SD_ERRORS
              int error = f_initvolume();
              if (error != F_NO_ERROR) {
                STDERR << "SD init error: " << error << "\n";
                extern void SaySDInitError(int error);
                SaySDInitError(error);
                return false;
              }
              error = f_checkvolume();
              if (error != F_NO_ERROR) {
                STDERR << "SD check error: " << error << "\n";

profezzorn · July 21, 2023, 10:01pm

The thing is: VERBOSE_SD_ERRORS doesn’t really do anything unless there is a failure.
It’s very weird that it would actually fix anything.

NoSloppy · July 21, 2023, 10:04pm

Right, but this part is NOT run, so something with this?

    if (!DOSFS.begin()) return false;
    if (!DOSFS.check()) {
      DOSFS.end();
      return false;
    }

profezzorn · July 23, 2023, 6:30pm

This functions just call f_initvolume() and f_checkvolume():

github.com

profezzorn/arduino-proffieboard/blob/6c36f58ef94e791734bcb69d8f20b40c40141ab6/cores/stm32l4/FS.cpp#L184


      
          bool Dir::next() {
              if (_find.find_clsno == 0x0fffffff)
                  return false;
          
          
    return (f_findnext(&_find) == F_NO_ERROR);
          }
          
          
FS::FS() {
          }
          
          
bool FS::begin()
          {
              return (f_initvolume() == F_NO_ERROR);
          }
          
          
void FS::end()
          {
              f_delvolume();
          }
          
          
bool FS::check()

NoSloppy · July 23, 2023, 6:54pm

Well if that’s basically the same then, are we dealing with the potential influence of compiler optimizations depending on whether VERBOSE_SD_ERRORS is defined or not?

It doesn’t seem like a delay would help since if there are no errors, the talkie and STDOUT don’t even occur (and taking up some time), but just to test, should we try adding a delay something like

    if (!DOSFS.begin()) {
      delay(1000); 
      return false;
}

?

Grasping for ideas here.

profezzorn · July 23, 2023, 6:57pm

This is why I think it might be a buffer overflow somewhere.
A buffer overflow is essentially a “holistic” error, because a problem in one part of the code can cause a symptom in another part of the code, and the link between the two can be determined by code order, optimizations and any combination of the two.

NoSloppy · July 23, 2023, 7:17pm

Are there some warnings flags we could enable when compiling that might point to a clue?

profezzorn · July 23, 2023, 7:45pm

no, there is not.