OPTIMIZE_TRCONCAT broken

ProffieOS
1

So this define exists, but causes the following error:

ProffieOS/transitions/concat.h:24:7: error: 'TrConcat3' is not a class template
   24 | class TrConcat3<A, INTERMEDIATE, B...> {
      |       ^~~~~~~~~
ProffieOS/transitions/concat.h:24:35: error: expansion pattern 'B' contains no parameter packs
   24 | class TrConcat3<A, INTERMEDIATE, B...> {
      |                                   ^~~
ProffieOS/transitions/concat.h:29:13: error: declaration of '~TrConcat' as member of 'TrConcat3<A, INTERMEDIATE, B>'
   29 |   ~TrConcat() {
      |             ^

and so on for a LONG time of cascading error messages.

Is it worth fixing? How much savings could this generate if used (if it worked) ?

2

No.
It does save some RAM and maybe even some CPU, but it has unexpected side effects.
If it doesn’t work anymore, we should just delete it.

3

PR submitted.

4

You probably need to also delete #endif at line 118 / 55. :wink:

5

Whoops. That was just an #else not #endif. Thanks for the catch.