Check style for effect use

NoSloppy · October 8, 2021, 5:02am

Is it possible to check whether or not an effect is called for in a blade style?
For example, If style uses EFFECT_PREON, then do this, else just do this.
Maybe something with current_preset_.GetStyle....?

profezzorn · October 8, 2021, 5:24am

Currently no, but it would be relatively simple to add to the style->IsHandled() function. There isn’t enough bits to do this for all the different effects though, so for each effect that you need to check for, we would need to add the code that maps the effect number to one of the bits in the “handled” bitfield.

The definition of that bitfield lives here right now:

github.com

profezzorn/ProffieOS/blob/305c70122ed78f41550e3d9f667cde559bb0d8a9/blades/blade_base.h#L8

    
      
          #ifndef BLADES_BLADE_BASE_H
          #define BLADES_BLADE_BASE_H
          
          
#include "../common/saber_base.h"
          
          
using BladeEffectType = EffectType;
          
          
  enum HandledFeature {
              HANDLED_FEATURE_NONE = 0,
              HANDLED_FEATURE_CHANGE = 1 << 0,
              HANDLED_FEATURE_CHANGE_TICKED = 1 << 1,
              HANDLED_FEATURE_STAB = 1 << 2,
              HANDLED_FEATURE_DRAG = 1 << 3,
              HANDLED_FEATURE_MELT = 1 << 4,
              HANDLED_FEATURE_LIGHTNING_BLOCK = 1 << 5,
            };
          
          
#include "../styles/blade_style.h"

What is it you’re trying to do? Maybe there is another way?

NoSloppy · October 8, 2021, 5:35am

Ha Most certainly probably a simpler way.
Working on that matching preon sound to blade effects thing…
Got it working, but seems clunky. Probably should be using a table or an array somehow, but…
The last issue with the way it is now is preon01, 02 and 03 always link to EFFECT_PREON1, 2 or 3, regardless if they exist in the blade style or not.
So if the style doesn’t have them, up to the first 3 preon sounds leave the blade black.
Well, not always. Only within #define PREONS_MATCH_BLADE_EFFECTS

NoSloppy · October 8, 2021, 5:54am

To more directly answer, I’m trying to only do
hybrid_font.DoEffect(EFFECT_PREON1, 0); if it exists in the blade style.
That way preon01 just does normal EFFECT_PREON if the style doesn’t specify a numbered version.

profezzorn · October 8, 2021, 6:53am

Maybe it would be better to do hybrid_font.DoEffect(EFFECT_PREON, 1);? Then alter the style to react differently based on the “location” (which is really the effect number in this case.)

NoSloppy · October 8, 2021, 7:05am

I was wondering about that argument! So it IS the effect number. Good lord that makes things better I think. Thanks.

Wait…alter the style?

NoSloppy · October 8, 2021, 7:42am

I’ve never seen location be anything but zero. How does that work?

profezzorn · October 8, 2021, 7:57am

Well, location was originally intended to be calculated from sensor data, especially for clashes. However, I not found a way to do that yet, so it’s either zero or random. However, that doesn’t mean it has to be.

Currently there is no way to get the location inside a style, because there is not real use for it, but it could be added.

Fett263 · October 8, 2021, 1:03pm

Just a note, this may not play nice with “Preon Options” for Edit Mode and in the OS6 library so please put any of these changes in a define. The “Preon Options” in the library will allow users to select from multiple preon effects within a single style via Edit Mode, including turning the effect off, so this doesn’t sound like it will work alongside this concept.

NoSloppy · October 8, 2021, 4:57pm

Stuff I’m playing with is only within an #ifdef PREONS_MATCH_BLADE_EFFECTS

Fett263 · October 8, 2021, 5:09pm

That works, just note that will probably not work so well with the Edit Mode / library styles so you’ll probably want to put some comments with that define in your prop.