Battery percentage incorrect?

ProffieOS
1

DId recent changes to sound_library maybe do something to the calculation for say SAY_WHOLE or something?
100% battery (4.15 volts) shows and speaks voltage correctly,
but percentage is spoken as 20% while showing the correct 100%.

Volts first:

          sound_library_.SayNumber(battery_monitor.battery(), SAY_DECIMAL);
          sound_library_.SayVolts();
          PVLOG_NORMAL << "Battery Voltage: " << battery_monitor.battery() << "\n";

01:01:36.722 → Battery Voltage: 4.15
01:01:37.889 → unit = 0 vol = 0.50, Playing ProffieOS_Voicepack_Skoll/common/mnum/mnum4.wav
01:01:37.924 → channels: 1 rate: 44100 bits: 16
01:01:38.389 → Playing mpoint.wav, channels: 1 rate: 44100 bits: 16
01:01:38.852 → unit = 0 vol = 0.50, Playing ProffieOS_Voicepack_Skoll/common/mnum/mnum1.wav
01:01:38.889 → channels: 1 rate: 44100 bits: 16
01:01:39.314 → unit = 0 vol = 0.50, Playing ProffieOS_Voicepack_Skoll/common/mnum/mnum4.wav
01:01:39.347 → channels: 1 rate: 44100 bits: 16
01:01:39.770 → Playing mvolts.wav, channels: 1 rate: 44100 bits: 16

But then percentage is:

          sound_library_.SayNumber(battery_monitor.battery_percent(), SAY_WHOLE);
          sound_library_.SayPercent();
          PVLOG_NORMAL << "Battery Percentage: " <<battery_monitor.battery_percent() << "%\n";

01:01:41.460 → Battery Percentage: 100.00%
01:01:41.460 → Playing battlevl.wav, channels: 1 rate: 44100 bits: 16
01:01:41.800 → EVENT: Power-Released#3 millis=1636476
01:01:41.800 → EVENT: Power-Released millis=1636476
01:01:42.638 → unit = 0 vol = 0.50, Playing ProffieOS_Voicepack_Skoll/common/mnum/mnum20.wav
01:01:42.673 → channels: 1 rate: 44100 bits: 16
01:01:43.327 → Playing mpercent.wav, channels: 1 rate: 44100 bits: 16

For reference, I just put this fresh battery in because percentage was saying 8% on the one I had in (while volts was reported as 3.52V)

2

I think I found the typo.

    int thousands = number / 1000;
    if (thousands) {
      SayWhole(thousands);
      Say1000();
      number %= 1000;
    }
    int hundreds = number / 1000;
    if (hundreds) {
      SayWhole(hundreds);
      Say100();
      number %= 100;
    }
3

If my “recent”, you mean April, then yes, I re-coded SayWhole()/SayNumber(), and possibly screwed them up.

4

Does it work better if you change / 1000 to / 100 ?

5

yes. was just submitting PR. Unless you just want to handle it

6

PR sounds perfect :slight_smile:

1 Like