Accent LED sharing same LED pad as Neopixel remain on for first retraction

ProffieOS Blade Styles
1

Probably a weird use case but I’ve done this for a few builds already and it works for the most part.

Use Case: For Neopixel builds, accent LEDs (illuminated AV switches) share the same LED power pads as the Neopixel LED pads. Such that the accent LEDs turn on when the main blade is ignited, and retract when the blade is retracted. No expectation of any ignition or retraction styling, just on and off. No config changes necessary to reflect this set up. Accent LEDs are resistored accordingly based on battery’s nominal voltage (3.7V)

Expect: Accent LED turns on when the Neopixel blade turns on and off when the blade turns off.

Actual: Only for the very first retraction after boot, the accent LED remains on. For subsequent ignitions then retraction, the accent LED turns off when the blade turns off.

Tested this setup only on a few Fett styles but unsure if this applies to all styles. Don’t have any reason to believe it only applies to his style library.

2

Does it go off on first retraction if you wait a little while? As opposed to just testing with quick on/off.

3

Please post your config file.
If you have a chance, can you try a simple style, like StyleNormalPtr<Blue, White>() and see if it behaves the same or not?

4

Yep tested on a simple InOut style and seeing the same issue. Only on the first retraction the piggybacked accent LED stays on.

#ifdef CONFIG_TOP
#include "proffieboard_v2_config.h"
#define NUM_BLADES 1
#define NUM_BUTTONS 2
#define BLADE_DETECT_PIN blade2Pin
#define VOLUME 1800
#define SAVE_STATE
const unsigned int maxLedsPerStrip = 144;
#define CLASH_THRESHOLD_G 4.0
#define ENABLE_AUDIO
#define ENABLE_MOTION
#define ENABLE_WS2811
#define ENABLE_SD
#define COLOR_CHANGE_DIRECT
#define DISABLE_DIAGNOSTIC_COMMANDS

#define IDLE_OFF_TIME 60 * 5 * 1000

#define FETT263_MOTION_WAKE_POWER_BUTTON
#define MOTION_TIMEOUT 60 * 10 * 1000
#define FETT263_SWING_ON
#define FETT263_SWING_ON_SPEED 350
#define FETT263_TWIST_OFF

#define AUDIO_CLASH_SUPPRESSION_LEVEL 1
#define FILTER_CUTOFF_FREQUENCY 50
#define FILTER_ORDER 8

#define ENABLE_ALL_EDIT_OPTIONS
#define FETT263_EDIT_MODE_MENU
#define DISABLE_BASIC_PARSER_STYLES

#endif

#ifdef CONFIG_PROP
#include "../props/saber_fett263_buttons.h"
#endif

#ifdef CONFIG_PRESETS
Preset presets[] = {
  {
    "SmthJedi;common", "",
    StylePtr<InOutHelper<White,300,800>>(),
    "smthjedi"
  }
};

BladeConfig blades[] = {
  {0,
    WS281XBladePtr<122, bladePin, Color8::GRB, PowerPINS<bladePowerPin2, bladePowerPin3>>(),
    CONFIGARRAY(presets)}
};
#endif

#ifdef CONFIG_BUTTONS
Button PowerButton(BUTTON_POWER, powerButtonPin, "pow");
Button AuxButton(BUTTON_AUX, auxPin, "aux");
#endif
5

Bumping the topic since it lost traction. Attached the minimal sample config above that reproduces the issue. Also updated to latest commit on master branch and it’s still present.

Tested with waiting after a few minutes on the first retraction and the accent LED remains on.

6

I think this should be fixed on github master now.

7

Confirmed fixed with the latest commits, thank you!