Should KILL_OLD_PLAYERS and NO_REPEAT_RANDOM just be defaults?

Anyone have a reason why these features would ever want to be turned off?

2 less defines to need to manage in every config.

I googled and couldn’t find any documentation about what they do,

what do they do?

Use POD :wink:

I think we can probably make them defaults, but we also need add defines for turning them off, just in case.

There are probably more defines that should just be on by default…

Like ENABLE_AUDIO?

Indeedliydoodly

I think we should at least default these to on:

#define KILL_OLD_PLAYERS
#define NO_REPEAT_RANDOM
#define ENABLE_AUDIO
#define ENABLE_MOTION
#define ENABLE_WS2811
#define ENABLE_SD

Anything else?

Seems complete to me. Not sure how you want to

double negatives?

#if !defined(ENABLE_AUDIO) && !defined(DISABLE_AUDIO)
#define ENABLE_AUDIO
#endif
1 Like

Looks like AUDIO/MOTION/WS2811/SD was already made on-by-default 7 months ago:

I guess I forgot. :slight_smile:

1 Like

Oh cool.
So I can delete those lines from my CONFIG_TOP going forward. :smiley:
Always good to have a tidy up. Thanks guys.
:pray: :+1:

Even though it was 7 months ago, it was still after the 7.x branch, which means that these defines will only be on by default in ProffieOS 8.x or newer.

2 Likes

Aha, got you.
Thanks Prof.
:slight_smile: