ProffieOS 8.7 beta (call for testers!)

ProffieOS
201

Yes, that’s what the circular menu is for.

1 Like
202

Most props don’t use the menues provided by common code though. I don’t think this the common volume menu provided by mode::SmothVolumeMode has this problem.

203

Ok, so it’s time to work on ProffieOS 8.x again.

I synced everything from the main branch to the v8 branch, made a new zip file and uploaded it in the top post for testing.

I also marked some things as tested based on searching the forum for posts and threads where people have already used these new features.

Changes in 8.5 compared to 8.4:

  • blaster oled stun support
  • props/hev.h
  • error messages cause other sounds to play with lower volume
  • new error messages: voice pack not found & error in voice pack
  • BC prop: button clicker
  • Fett263 prop: button clicker
  • Fett263 prop: FONT_PATTERN support
  • Sabersense prop: Many changes
  • Faster lookup for voicepack files + alt support for voicepack files
  • Some bugfixes and whitespace cleanup
2 Likes
204

re: OS 8.5

“Voice Pack Not Found” plays as “Muresev Not Found”, a little too garbled IMHO.

Also post flash now (yeah I still pull my SD’s out for flashes) Arduino loses the port listing whereas before if you left things connected you could still have the port come back up in the listing.

Also I’m seeing one time out of say 5-7 flashes you get Arduino NOT keeping the progress bar progressing, stopping after 10%, it shows the printout Completed but no audio confirmation from the board happens. *Yes I am on the correct Arduino version and Plugin and it’s not a “Mac thing.”

*That said for some reason now if using Force Sync it’ll pair to an iPhone way faster and you get a few more feet of range to mess with people. I’ll report this as a cc to that topic.

205

This is behavior that comes and goes for me. (for years) I’m not sure what causes it.
Are you saying this reliably happens with OS8, but not with OS7? (or previous versions of OS7?)

I don’t think the ProffieOS code can cause this, because it’s not running when flashing is happening. Maybe an Arduino or hardware problem?

Again, not something that ProffieOS can affect.

206

  • It’s never done it before on the Macs unless I switch between two different boards. Not even with OS7. Yes it looks like it’s reliably happening because I’ve switched back to OS7 and ran (laughing as I type this) 12 flashes and it never appeared. So switching back again to OS8.5 for 6 flashes it’s doing it again.

  • I can go in another day and yank out Arduino and run a fresh download. I doubt it’s because of any difference between 1.18.x and my now running 2.x.x or that I have mine set up with the DarkMode tricks for 2.x.x

  • I know, just saying is all since for me it related as far as something I noticed.
    Not sure why though and will keep it to that topic going forwards.

THX! Up way too late tonight.

207

*Edited the reply above for clarity.

208

Tested HardStripes, found and fixed a bug, so there will definitely be an 8.6 soon.

209

Hey prof, did you make a decision on whether or not your going to add a bgnidle.wav sound effect for OS8

210

I’m going to go with yes, because it’s in the code…

1 Like
211

Tested TransitionLoopWhileL, found some bugs and fixed them. (fixes will be in 8.6)

212

Talk to me about LeftRightRotaryReceiver and does it pertain to an ability to switch rotary controls from a righthand defined twist to a lefthand defined one? Because Southpaw

213

No, it translates rotary input to menu controls.

214

Got it. Thanks

215

Created a 8.6 zip (link in top post).
Same as 8.5, but with bugfixes for HardStripes and TransitionLoopWhileL, plus some code cleanup.

I think we’re getting pretty close, it’s mostly menu stuff that needs some more testing.

2 Likes
216

I have a few more readability improvements suggestion in some props but I would need permission of the respective owners for PR’s:
@Fett263:

  • There are a few indentation errors.
  • Many functions could be separated from each other with an empty line for improved readability.
  • Several #endif could benefit from an " // ENDIF_COMMENT" especially when they are far away from their respective #if or when there are several #endif next (or very close) to each other
  • The top of the prop description has some very long lines that could be split into two. My laptop has a wide screen but not nearly wide enough to avoid having to repeatedly having to scroll right and left in order to read everything.

I can have 1 or even 4 PR’s ready to go, if you allow ? No code will be changed.

@Sabersense:

  • add a few // ENDIF_COMMENT" when there are several #endif next (or very close) to each other.
  • Your whole “bool Event2” should be indented two more spaces to be consistent with the rest of ProffieOS.
  • You have several rogue end of line spaces.
  • There are a few pairs of “{” & “}” that don’t need to be there.
  • Code improvement: replace “#if NUM_BUTTONS == 2” with “#if NUM_BUTTONS >= 2”

That’s it. @Fett263 & @Sabersense, I really don’t mind and I would be honored to do these cosmetic PR’s, if you allow me?

1 Like
217

Thanks for the observations Olivier.

I have a small PR already submitted, so I’ll wait for that to clear first before I submit your mods, but taking them in turn:

  • Yeh, I’ve gone through and added a few such comments for clarity.
  • Most of bool Event2 is inherited, so I think I’m gonna leave it as is.
  • My software doesn’t show those end spaces easily and I couldn’t see any. But I’ve now run a Normalize to sweep them out. If it hasn’t worked and some are left, then yes, feel free to clear them out yourself as it sounds like your software is a bit better than mine.
  • I tweaked a couple of instances of bracketing, but I think the rest I want to leave for clarity.
  • The buttons ==2 thing is deliberate because if I do ever add a third button, I would want to make a point of going through every single button instance to check for conflicts, so again, I’m going to leave it nailed down to two buttons max.
1 Like
219

ProffieOS needs a .clang-tidy, is what you’re saying :sweat_smile:

220

I did that already last week. I did PR’s for prop_base.h, ssd1306.h, layer_controller.h, several files from /styles/, and more.

Just trying to make it clean and “easier” to read for everyone before a move from beta to official. But someone here prefers to keep his code with indentation errors and harder to read because he doesn’t want to deal with my “level of crazy” ! (yeah, I saw that in the deleted post!) :rofl:

I can see them when the text is selected/highlighted for copy/paste. You can look at the end of each lines, if more than one “space” (or zero if your software doesn’t “shows” next line hidden character) is highlighted, then you have extra end of line spaces.

1 Like
221

I was going to test a few more menu things today, but it turns out that the sound queue was very broken. (I thought I had tested the new code, but apparently I had not.)

Anyways, that is fixed on master now, so maybe I can get to testing the menus soon.
Expect an 8.7 zip file shortly.