I’m going through the diff on effects and fount out CLASH_UPDATE was added on 6.x but is not documented. Is this a documentation error or is it an internal effect not to be used?
On a separate note, I see that 4.x had no effects. Is that so or was it moved from another file? I mean, I’m just looking at sabe_base.h, may be effects were on a different file in 4.x?
CLASH_UPDATE is special, and you can’t use it in blade styles.
It should probably still be documented though.
In 4.x and earlier, we had separate functions for each effect.
However, once we started to have a lot of effects, having one function and an enum was a lot more efficient.
Ok, every new feature in 7.x now has some level of documentation!
Wow, thank you for that, that’s a lot of work.
edit - Oh wait. And not detracting from this linkage effort, but…actual descriptions coming?
Like EFFECT_SECONDARY_IGNITION for example?
Doing my research on the evolution of ProffieOS, I found @profezzorn Thermal Detonator page. So, I wonder if that prop even works nowadays, or if still uses the correct events.
It should work. (Although it’s been a while since I upgraded my TD…)
Besides, the functions that generate events used in 4.x still exists, but those functions just call the new function with the right enum value now.