Oops. Sound Library re-do needs fix?

Latest Git master.
BC prop from 7.14 (minus defining EFFECT quote)

Enter volume menu (hold POW and Clash), vmbegin plays OK.
Change volume (via rotation), sounds play OK.
Exit volume menu (hold POW and Clash), vmend plays OK.
All is well and that looks like this:

00:21:32.203 -> EVENT: Power-Pressed#1 millis=16746
00:21:32.203 -> EVENT: Power-Pressed millis=16746
00:21:32.447 -> EVENT: Clash mods Power millis=17006
00:21:32.447 -> Enter Volume Menu
00:21:32.447 -> Playing vmbegin.wav, channels: 1 rate: 44100 bits: 16
00:21:32.728 -> EVENT: Power-Released#1 millis=17258
00:21:32.728 -> EVENT: Power-Released millis=17258
00:21:33.932 -> unit = 0 vol = 0.50, Playing common/volmin.wav
00:21:33.965 -> channels: 1 rate: 44100 bits: 16
00:21:33.965 -> Minimum Volume
00:21:34.775 -> EVENT: Power-Pressed#1 millis=19321
00:21:34.775 -> EVENT: Power-Pressed millis=19321
00:21:35.057 -> EVENT: Clash mods Power millis=19605
00:21:35.057 -> Exit Volume Menu
00:21:35.057 -> Playing vmend.wav, channels: 1 rate: 44100 bits: 16
00:21:35.373 -> EVENT: Power-Released#1 millis=19908
00:21:35.373 -> EVENT: Power-Released millis=19908

However, if NO volume change is made, vmend does not play.
Serial Monitor says it can’t find the sound, and there’s an extra “av” on the “.wav” in the message. strange.

00:21:24.028 -> EVENT: Power-Pressed#1 millis=8585
00:21:24.028 -> EVENT: Power-Pressed millis=8585
00:21:24.346 -> EVENT: Clash mods Power millis=8870
00:21:24.346 -> Enter Volume Menu
00:21:24.346 -> Playing vmbegin.wav, channels: 1 rate: 44100 bits: 16
00:21:24.634 -> EVENT: Power-Released#1 millis=9181
00:21:24.634 -> EVENT: Power-Released millis=9181
00:21:25.632 -> Amplifier off.
00:21:25.877 -> EVENT: Power-Pressed#1 millis=10434
00:21:25.877 -> EVENT: Power-Pressed millis=10434
00:21:26.193 -> EVENT: Power-Held#1 millis=10735
00:21:26.193 -> EVENT: Power-Held millis=10735
00:21:26.193 -> EVENT: Clash mods Power millis=10749
00:21:26.193 -> Exit Volume Menu
00:21:26.193 -> Playing vmend.wav, File common/vmend.wavav not found.
00:21:26.444 -> EVENT: Power-Released#1 millis=10975
00:21:26.444 -> EVENT: Power-Released millis=10975

I put a debug printout in the code in the VolumeMenu() function for

      if (SFX_vmend) {
STDOUT << "********* We have SFX_vmend\n";
        sound_library_.SayVolumeMenuEnd();

and it shows, so it does find the sound and is calling sound_library.
I don’t understand why playing volume change sounds first would make it happy, but it does for some reason.
7.14 official release doesn’t have this issue, so I have to assume it’s something in the revamp of sound_library.h?

*Edit - Also, this is not file specific, as in, any other voicepack does it the same.

Follow up.
It’s only when no volume change OR if the last volume change was a decrease, then it doesn’t play vmend.

So like
Enter > Exit does not work.
Enter > up > Exit works.
Enter > down > Exit does not work.
Enter > down > up > Exit works.
Enter > down > up > down >Exit does not work
Enter > up > down > Exit does not work.

Last reply for now.
Not sure if there’s a hard rule to what symptoms are because I just had this where it wouldn’t even play vmbegin

Playing vmbegin.wav, File ProffieOS_Voicepack_Skoll/common/vmbegin.wavd.wavav not found.

vmbegin.wavd.wavav ??

But, then on a subsequent try, it played fine.
:person_shrugging:

Try it now.

Very good, thanks.
I guess I should have submitted it as an issue?

A thread here is fine, especially if you’re not sure what’s going on with it.