Hi All
wasn’t sure where to post this but i thought i’d start having a play with the latest master on github and have run into a couple problems with the fett263 prop file
first one i have had to comment out "EFFECT(quote); // quote on force effect " on line 853
this then leads to highlighting a spelling mistake on line 4791 and minimum is spelt mininum
That tracks.
Quote has been moved into saber base itself so no need to declare it at the prop level.
The typo has been fixed in sound library, so calls to that sound will need to be updated to the correct spelling.
Chances are you’ll also have an issue with ColorChange mode, although the Fett263 prop uses custom handling of feature so it may or may not be affected as-is by the new modes system that has been implemented.
These things should have been fixed when we made those changes though.
Should be fixed now.
If this is not too much work (for you) could we dabble? It would likely be the last change I’d work on adding to my prop to go along with the rest of similar things.
I’ll see what I can do.
I see some changes to lockup have been made. So I assume to set a location for the lockup, it would need to use something like
SaberBase::SetLockup(SaberBase::LOCKUP_LIGHTNING_BLOCK, location);
SaberBase::DoBeginLockup();
with the prop setting a condition specifying what location is?
It would be cool if you could write out an example EVENTID case showing what it should look like?
SetLockup doesn’t actually take a location, just a BladeSet.
For a dual-blade setup, I think we’d just want to do the lockup on whichever blade is “up”, which would could look something like this:
// Lockup
case EVENTID(BUTTON_NONE, EVENT_CLASH, MODE_ON | BUTTON_POWER):
if (!SaberBase::Lockup()) {
SaberBase::SetLockup(SaberBase::LOCKUP_NORMAL,
BladeSet.fromBlade(accel_.x < 0 ? BC_MAIN_BLADE : BC_SECONDARY_BLADE));
SaberBase::DoBeginLockup();
return true;
}
break;
@profezzorn What’s the rule again on variables as far as trailing underscores?
I know you like bools to have them. When do they NOT get one?
Like if I were to make one for this BladeSet, underscore or no on effect_blade
BladeSet effect_blade = BladeSet.fromBlade(accel_.x < 0 ? BC_MAIN_BLADE : BC_SECOND_BLADE);
I use underscores for instance variables. (Meaning that they live in the class.) Local and global variables do not get underscores. It can be a bit confusing since many of our objects are singletons, which means that variables have the same lifetime as a global variable.
The type of the variable doesn’t matter though.
Reminder to self: Test new parameters
High2LowSeparationDegrees=120
Low2HighSeparationDegrees=60
Transition1Degrees=45
Transition2Degrees=45
Curious if we’re getting close to an alpha. Any news?
I was hoping to be there by now, not being able to release the 4.1 version of the arduino-proffieboard plugin because of compiler bugs has made things more difficult.
The best way to speed it up is to help test stuff. 
How can I help, seeing as I wont have access to the serial monitor and I can only upload configs via St-link.
Some of it is just trying to use some of the new functionality on github master. Certain things will be harder to figure out without a serial monitor, but I suppose you may be able to use debugging instead…
Is there a particular list anywhere of things you’re wanting tested? Typically it’s easier for me to target specifics than a general “everything” type of request.
uploaded os 8, enabled most of the defines and tested volume menu while off,
1 button setup
volume is set to Hold PWR + Clash, it triggers a force sound and turns saber on. no volume control.
incendiusv8.h (149.2 KB)
seems to be a clash thing, because gesture sleep is point down hold pwr + clash as well and that didn’t work either. let me see if there’s any other clash events that aren’t working.
enabled spin mode and no clashes detected. test run was for 15 seconds.
UPDATE : I had reverted back to 7.14 and I couldn’t get the volume menu to work,
either my board is faulty (unlikely cause I can clash) or the clash threshold is too high
#ifdef CONFIG_TOP
#include "proffieboard_v2_config.h"
#define NUM_BLADES 1
#define NUM_BUTTONS 1
const unsigned int maxLedsPerStrip = 144;
#define EXTRA_COLOR_BUFFER_SPACE 60
#define VOLUME 1550
#define CLASH_THRESHOLD_G 3
#define AUDIO_CLASH_SUPPRESSION_LEVEL 10
#define PROFFIEOS_ACCELEROMETER_RANGE 16
#define PROFFIEOS_MOTION_FREQUENCY 1600
#define ACCEL_MEASUREMENTS_PER_SECOND 800
#define ENABLE_AUDIO
#define ENABLE_MOTION
#define ENABLE_WS2811
#define ENABLE_SD
#define KILL_OLD_PLAYERS
#define FILTER_CUTOFF_FREQUENCY 100
#define FILTER_ORDER 8
#define MOTION_TIMEOUT 60 * 15 * 1000
#define IDLE_OFF_TIME 60 * 15 * 1000
#define DISABLE_BASIC_PARSER_STYLES
#define DISABLE_DIAGNOSTIC_COMMANDS
#define ENABLE_ALL_EDIT_OPTIONS
#define SAVE_PRESET
#define NO_REPEAT_RANDOM
#define COLOR_CHANGE_DIRECT
#define FETT263_EDIT_MODE_MENU
#define FETT263_DUAL_MODE_SOUND
#define FETT263_CLASH_STRENGTH_SOUND
#define FETT263_MAX_CLASH 16
#define FETT263_SPIN_MODE
#define FETT263_QUICK_SELECT_ON_BOOT
#define FETT263_SAY_COLOR_LIST
#define FETT263_SAY_BATTERY_PERCENT
#define FETT263_QUOTE_PLAYER_START_ON
#define FETT263_SAVE_GESTURE_OFF
#define FETT263_LOCKUP_DELAY 200
#define FETT263_BM_CLASH_DETECT 6
#define FETT263_BM_DISABLE_OFF_BUTTON
#define FETT263_SWING_ON_SPEED 250
#define FETT263_SWING_ON
#define FETT263_TWIST_ON_PREON
#define FETT263_THRUST_ON
#define FETT263_THRUST_ON_NO_BM
#define FETT263_STAB_ON_PREON
#define FETT263_STAB_ON_NO_BM
#define FETT263_TWIST_OFF
#define FETT263_FORCE_PUSH_ALWAYS_ON
#define FETT263_FORCE_PUSH_LENGTH 3
#define FETT263_MOTION_WAKE_POWER_BUTTON
#define FETT263_DISABLE_COPY_PRESET
#endif
this is for webusb right? I was gonna test this out but now I realise I have the web but no usb. lol
I’ll remove my previous comment that’s more fett263 prop file issues then the os8 right?
No, it is a in-hilt menu system.
It doesn’t work with the fett263 prop though.
It is currently only available for the “saber” prop, but will soon also be available for the BC prop. The define you need to enable it is in the post you commented on. Also you need a V2 voice pack.
I typically make that list when I get to alpha stage.
The menu you talked about above is the thing that needs the most testing though.
sorry I don’t see where that define is.