Configure boot volume vs max volume?

profezzorn · June 18, 2022, 1:18am

The language is C++.

Actually, probably the right implementation is to change this line:

profezzorn/ProffieOS/blob/6495dda7bff12ab27ba19a1de775403a41ded80d/sound/dynamic_mixer.h#L188

    
      
            void set_volume(int32_t volume) { volume_ = volume; }
            int32_t get_volume() const { return volume_; }
          
          
  ProffieOSAudioStream* streams_[N];
            int32_t vol_ = 0;
            int32_t last_sample_ = 0;
            int32_t last_sum_ = 0;
            int32_t peak_sum_ = 0;
            int32_t peak_ = 0;
            int32_t num_samples_ = 0;
            int32_t volume_ = VOLUME;
            volatile uint32_t underflow_count_ = 0;
            uint32_t last_underflow_count_ = 0;
            uint32_t last_printout_ = 0;
          //  int32_t sum_;
          //  ClickAvoiderLin volume_;
          };
          
          
AudioDynamicMixer<NUM_WAV_PLAYERS + 2> dynamic_mixer;
          
          
#endif

to:

#ifndef BOOT_VOLUME
#define BOOT_VOLUME VOLUME
#endif
 int32_t volume_ = BOOT_VOLUME;

Although the #ifdef might be better to put somewhere else, like after the CONFIG_TOP include in ProffieOS.ino, that way BOOT_VOLUME could be used anywhere in the code.